search

HPInc / HP-Digital-Microfluidics

HP Digital Microfluidics Software Platform and Libraries
MIT License
3 stars 1 forks source link

Issue.071 #194

Closed EvanKirshenbaum closed 8 months ago

EvanKirshenbaum commented 8 months ago

This is about ready to be merged in master. It currently sets up a Python 3.9 and 3.10 setup and runs mypy for all files in mpam/src. It runs on both push and pull_request events in GitHub. It does not stop us from pushing or merging pull requests, but it will advise us if the mypy reports any issues.

I had to do a lot of small commits to debug agains GitHub Actions. There is no point in keeping the individual commits, we should squash and merge.

Migrated from internal repository. Originally created by Rares Vernica on Aug 16, 2022 at 8:04 AM PDT. Closed on Aug 18, 2022 at 11:27 AM PDT.
EvanKirshenbaum commented 8 months ago

This issue was referenced by the following commit before migration:

EvanKirshenbaum commented 8 months ago

TODO:

EvanKirshenbaum commented 8 months ago

Here are the arguments I currently give to MyPy:

--follow-imports=silent --show-column-numbers --ignore-missing-imports
--warn-redundant-casts --warn-return-any --warn-unreachable
--strict-equality --show-error-codes
Migrated from internal repository. Originally created by @EvanKirshenbaum on Aug 16, 2022 at 11:52 AM PDT.
EvanKirshenbaum commented 8 months ago

@EvanKirshenbaum I took care of all TODOs.

Migrated from internal repository. Originally created by Rares Vernica on Aug 16, 2022 at 1:12 PM PDT.