HPInc / HP-Digital-Microfluidics

HP Digital Microfluidics Software Platform and Libraries
MIT License
3 stars 1 forks source link

Abstract OpenDrop firmware logic to work for both OpenDrop and Wombat #198

Open EvanKirshenbaum opened 8 months ago

EvanKirshenbaum commented 8 months ago

The curent wombat code handles multiple versions of the OpenDrop firmware (specifically versions 4.0 and 4.1) and their different communication protocols. Unfortunately, the opendrop device model assumes version 4.0 firmware.

I need to abstract out the firmware logic so that it can be shared between opendrop and wombat.

Migrated from internal repository. Originally created by @EvanKirshenbaum on Sep 13, 2022 at 12:47 PM PDT.
EvanKirshenbaum commented 8 months ago

The most recent commit in the issue.198 branch (fd4361f3a8106dca29e6772cbe300f6c2806210d) appears to do this. There's now an OpenDropFirmware class that encapsulates all of the communication and is used by both opendrop and wombat.

It seems to work with an OpenDrop v4.0 board, and doing some spot checks it looks as though it should work with a Wombat board, but I don't have a Wombat board to test it on, nor do I have a v4.1 OpenDrop board. (Much less a v4.2 board (#199).)

If somebody with a v4.1 OpenDrop and a Wombat board (@cumbiem? Corey Downs?) could check out the issue.198 branch and test it a bit before I merge it into master, I'd appreciate it.

Migrated from internal repository. Originally created by @EvanKirshenbaum on Sep 13, 2022 at 3:04 PM PDT.