HPInc / HP-Digital-Microfluidics

HP Digital Microfluidics Software Platform and Libraries
MIT License
3 stars 1 forks source link

Make OT-2 looping protocol work with only small pipettor #202

Closed EvanKirshenbaum closed 8 months ago

EvanKirshenbaum commented 8 months ago

I did adjust the ot2.json to our setup (we only have the small pipettor on the right side.

I'd actually be surprised if the OT2 protocol didn't die if you didn't specify both pipettors, as it was written with the assumption that they would both be there.

I can probably change things pretty easily to work with only the small pipettor. (If you only have the large one, you won't be able to dispense a small enough volume, but with only the small one, it'll just make more trips.) Let me see what I can do.

Originally posted by @EvanKirshenbaum in https://github.com/HPInc/HP-Digital-Microfluidics/issues/201 [comment by @EvanKirshenbaum on Sep 15, 2022 at 3:38 PM PDT]

Migrated from internal repository. Originally created by @EvanKirshenbaum on Sep 15, 2022 at 3:38 PM PDT. Closed on Sep 15, 2022 at 5:29 PM PDT.
EvanKirshenbaum commented 8 months ago

This issue was referenced by the following commit before migration:

EvanKirshenbaum commented 8 months ago

A little trickier than I had thought it would be, as the (simple) change uncovered that the control path when multiple trips are needed (because the requested amount didn't fit in the pipettor) had a couple of bugs in it, including forgetting to update a variable, which caused an infinite loop.

Mark Huber: You should be good to go now.

Migrated from internal repository. Originally created by @EvanKirshenbaum on Sep 15, 2022 at 5:29 PM PDT.
EvanKirshenbaum commented 8 months ago

thanks !

Migrated from internal repository. Originally created by Mark Huber on Sep 15, 2022 at 7:35 PM PDT.