search

HPSCTerrSys / TSMP

Terrestrial Systems Modelling Platform (TSMP or TerrSysMP)
https://www.terrsysmp.org/
Other
23 stars 15 forks source link

Replace outdated generic `parflow` directory with ParFlow3.9 #127

Closed jjokella closed 1 year ago

jjokella commented 2 years ago

Currently the component model build scripts for parflow are outdated and - to my knowledge - not used.

Proposal: Replace parflow with the files currently found in parflow3_9.

Rename old parflow files into a new directory called parflow3_0.

kvrigor commented 2 years ago

Good solution. We need to be sure if parflow is indeed unused.

@niklaswr does the TSMP monitoring system use the scripts in the parflow dir? Do you also know if there are other setups that use these scripts?

niklaswr commented 2 years ago

Good solution. We need to be sure if parflow is indeed unused.

@niklaswr does the TSMP monitoring system use the scripts in the parflow dir? Do you also know if there are other setups that use these scripts?

Not sure I understood what you mean. If TSMP is compiling, my setups and the monitoring setup should be fine.

However, I fully agree in removing outdated files to keep things clean. Even if this breaks some setups, those can still use the 'old' version / tag of TSMP which was working. I would not try to be backwards compatible too much, as I think this is the source of all mess :)

kvrigor commented 2 years ago

I think we all agree with the solution. @jjokella you may proceed with the proposed changes

jjokella commented 1 year ago

Updated some pathnames in #150