search

HPSCTerrSys / TSMP

Terrestrial Systems Modelling Platform (TSMP or TerrSysMP)
https://www.terrsysmp.org/
Other
23 stars 15 forks source link

build: `bindir` input (from flag `-B`) applied to rootdir #239

Closed jjokella closed 2 weeks ago

jjokella commented 2 weeks ago

Example: Before this PR, the command

./build_tsmp.ksh -c clm5-pdaf -m JURECA -O Intel -B bin/JURECA_clm5-pdaf-debug

created the bindir inside bldsva, i.e.

$rootdir/bldsva/bin/JURECA_clm5-pdaf-debug

After this PR bindir is created in the $rootdir. This is how the default-bindirs are placed:

$rootdir/bin/JURECA_clm5-pdaf-debug

Additionally, it is safer to use an absolute path in finalizeSelection.

jjokella commented 2 weeks ago

Note: I removed these changes again from master, as the bindir input is supposed to be an absolute path.

https://github.com/HPSCTerrSys/TSMP/blob/4d94a5fd2df64a503c406d845bde737ec1e1f803/bldsva/build_tsmp.ksh#L895

One could think about adding a check but this is not needed as TSMP2 is going to be the code used in the future.