move setting of local_dims_obs to dimension-setting-code
local_dims_obs was before set at the end of the global observation
initalization routines. However, it is more fitting to set it in the
code-part, where the observation dimensions are set, not after the
code part, where observation arrays are filled.
deallocate local_dims_obs at the very end of code
Before local_dims_obs was only deallocated directly before
allocation.
move allocation and gather of local_dims_obs again
removed unnecessary local array local_dim
local_dim is local clone of local_dims_obs. Therefore, local_dim
is removed and its role in setting the array local_dis is now filled
by local_dims_obs.
rename local_dis to local_disp_obs and add to mod_assimilation
clearer name local_disp_obs
preventing code duplicity of setting local_dis
simplified usage in observation operator routine
Disadvantage:
No immediate deallocation in local routine, should be ok as
local_disp_obs islength of number of PEs.
simplify obs_op_f_pdaf
use dim_obs_p where possible
check that dim_obs_p is local_dims_obs(mype_filter+1)
move setting of
local_dims_obsto dimension-setting-codelocal_dims_obswas before set at the end of the global observation initalization routines. However, it is more fitting to set it in the code-part, where the observation dimensions are set, not after the code part, where observation arrays are filled.deallocate
local_dims_obsat the very end of codeBefore
local_dims_obswas only deallocated directly before allocation.move allocation and gather of
local_dims_obsagainremoved unnecessary local array
local_dimlocal_dimis local clone oflocal_dims_obs. Therefore,local_dimis removed and its role in setting the arraylocal_disis now filled bylocal_dims_obs.rename
local_distolocal_disp_obsand add tomod_assimilationlocal_disp_obslocal_disDisadvantage: No immediate deallocation in local routine, should be ok as
local_disp_obsislength of number of PEs.simplify
obs_op_f_pdafdim_obs_pwhere possibledim_obs_pislocal_dims_obs(mype_filter+1)