search

HPSCTerrSys / TSMP2

CMake-based TerrSysMP
https://github.com/HPSCTerrSys/TSMP
1 stars 2 forks source link

Should we use more tags for identifying component model commits for cloning? #18

Closed jjokella closed 6 months ago

jjokella commented 6 months ago

I have just worked on an issue with CLM5 externals that are loaded by using tags and I came to think that it may be beneficial to clone TSMP2 component models from tags as well.

Mostly the advantage would be that the cloned component models always stay constant making room for active development on the branches without messing up any running setups.

ParFlow, is already cloned from tags: git clone -b v3.12.0 https://github.com/parflow/parflow.git. Therefore my question is, whether to adopt cloning from tags for all component models, for which this is possible.

If I get positive feedback - I will start adopting "cloning from tags" for the PDAF-patched component models.

kvrigor commented 6 months ago

+1 to tagging component model versions. It encourages stable and reproducible setups. Also the tag would be logged during the configure step:

-- ══════════════════════════════════════════════════
-- Building »eCLM-ParFlow« DEBUG version
--   OASIS3-MCT: aug-2023
--   eCLM: 58a94da
--   ParFlow: v3.9.0-90-g9ab87ecd
-- ══════════════════════════════════════════════════
jjokella commented 6 months ago

Added tag-based cloning in README for ParFlow (PDAF-patched): https://github.com/HPSCTerrSys/TSMP2/commit/ac73fea9ed97ad9fb76063faffa8ceef8ff4cc2f

jjokella commented 6 months ago

I have now added tags in the README for: Two component models

Coupler

Data assimilation

For the currently non-tagged component models, I will open issues in the corresponding repositories and close this issue