search

HPSCTerrSys / eCLM

Fork of Community Land Model v5.0
https://hpscterrsys.github.io/eCLM/
Other
8 stars 13 forks source link

Introduce `cime_run(ntsteps)`, callable for TSMP-PDAF #36

Closed jjokella closed 3 months ago

jjokella commented 3 months ago

  1. Re-introduce private statement, this was removed because variables from cime_comp_mod had to be used by TSMP-PDAF

  2. Add cime_run with number of time steps ntsteps as input. ntsteps is supplied by the TSMP-PDAF interface.

  3. Add stop_alarm for cime_run dependent on ntsteps.

jjokella commented 3 months ago

Draft status: Waiting for testing of corresponding TSMP-PR: https://github.com/HPSCTerrSys/TSMP/pull/229

kvrigor commented 3 months ago

@jjokella there are some changes here that overlap with #35; should that PR be already merged or do you prefer to have this PR merged instead?

jjokella commented 3 months ago

I merged #35, which makes the commit history of this PR a bit ugly. After squashing this PR, everything should be in order again!

I am now waiting for https://github.com/HPSCTerrSys/TSMP/pull/229. When this TSMP-PR is merged, I think this PR could follow for TSMP2.

jjokella commented 3 months ago

https://github.com/HPSCTerrSys/TSMP/pull/229 is tested and merged. All changes are under #ifdef USE_PDAF. So I propose merging this PR>