HPWebdeveloper / laravel-pay-pocket

A modern multi-wallet Laravel 10,11 package with comprehensive logging and payments capabilities and more than 3.5k installed
https://github.com/HPWebdeveloper/demo-pay-pocket
MIT License
272 stars 30 forks source link

Modify config #32

Closed HPWebdeveloper closed 2 months ago

HPWebdeveloper commented 2 months ago

https://github.com/HPWebdeveloper/laravel-pay-pocket/blob/28be370ec1285390fd142ced583fcc10c4a0db26/config/pay-pocket.php#L25

As the log reference is now flexible to get custom class and static methods like, random I believe this 'log_reference_length' is not general and it should be 'log_reference_parmas' and the default value should be [12] instead of 12

In this way we let the params to have values like this [...,...,...]

@3m1n3nc3 Can you modify this?

3m1n3nc3 commented 2 months ago

I remember we had it this way initially before if was removed by a pull request, let do it.

HPWebdeveloper commented 2 months ago

@3m1n3nc3 Yes I see, https://github.com/HPWebdeveloper/laravel-pay-pocket/pull/16#issuecomment-1890935024

The initial approach was too complex. please make it simple.

3m1n3nc3 commented 2 months ago

I opened a new pull request https://github.com/HPWebdeveloper/laravel-pay-pocket/pull/33

HPWebdeveloper commented 2 months ago

I opened a new pull request

thanks

HPWebdeveloper commented 2 months ago

well done! @3m1n3nc3