search

HQJaTu / NPPTextFX

TextFX plugin for Notepad++
Other
118 stars 37 forks source link

Insert Line Numbers causes buffer write beyond end #14

Open MGNute opened 4 years ago

MGNute commented 4 years ago

Hello. When I use the function in Tools --> Insert Line Numbers with any text highlighted, it causes an error that shuts down NPP. I re-built the solution included in the "VS2017" branch and had the same issue, so I also built with debug mode and tried that DLL. The same command with that library produces a dialog that says "buffer write beyond end" rather than shutting down.

Here is a quick printout of my sytem info, in case it is helpful: OS Name Microsoft Windows 10 Pro Insider Preview Version 10.0.19541 Build 19541 Other OS Description Not Available OS Manufacturer Microsoft Corporation System Name LAPTOP-37VS40RN System Manufacturer ASUSTeK COMPUTER INC. System Model UX550VE System Type x64-based PC System SKU Processor Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz, 2808 Mhz, 4 Core(s), 8 Logical Processor(s) BIOS Version/Date American Megatrends Inc. UX550VE.307, 4/19/2019 SMBIOS Version 3.0 Embedded Controller Version 255.255 BIOS Mode UEFI BaseBoard Manufacturer ASUSTeK COMPUTER INC. BaseBoard Product UX550VE

HQJaTu commented 4 years ago

Well. As you may have noticed, I haven't had much time and resources to contribute into this project.

The bug you're describing might be because not all of the features in TextFX have been ported into 64-bit. Line numbering is one of those. The obvious fix is to confirm the code would actually work in 64-address space.