HR / Crypter

🔓✨🔒 An innovative, convenient and secure encryption app
https://git.io/Crypter
MIT License
454 stars 70 forks source link

[Linux] desktop file does not pass desktop-file-validate #36

Closed probonopd closed 6 years ago

probonopd commented 7 years ago

desktop-file-validate says crypter.desktop: error: value "Utility" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character.

Reference: https://travis-ci.org/AppImage/appimage.github.io/builds/266072264

(Link edited.)

HR commented 6 years ago

The reference link seems to be broken 😞. Are you still experiencing this issue? Try building it on your machine.

probonopd commented 6 years ago

Fixed link. https://travis-ci.org/AppImage/appimage.github.io/builds/266072264 Building is not the issue, it's the invalid desktop file that is. Please run it through desktop-file-validate and make sure there are no errors reported, thanks.

Probably adding a ; after Categories=Utility is sufficient.

HR commented 6 years ago

I do not have direct control over the Linux build process. Crypter uses electron-builder to build the bin. The category is declared at https://github.com/HR/Crypter/blob/dev/package.json#L62 so you can try adding a semi colon there.

probonopd commented 6 years ago

By using the latest version of electron-builder this should be fixed automatically. Please let me know once a new build is available on GitHub Releases using the latest version of electron-builder, then I can run it through the test again. Thank you very much.

HR commented 6 years ago

OK Crypter v3.1 is now available as a pre-release on GitHub. Let me know if it passes the test so I can make it official 😄 Thanks for reporting this issue.

probonopd commented 6 years ago

Thanks, I confirm :+1:

HR commented 6 years ago

Awesome 😎