Consistent "id" types for recovered objects

HS-Datadesk / koronavirus-avoindata

HS julkaisee Suomen koronavirustartunnat avoimena datana.

https://www.hs.fi/aihe/koronavirus/

MIT License

100 stars 27 forks source link

Consistent "id" types for recovered objects #31

Closed lovelldies closed 4 years ago

lovelldies commented 4 years ago

The values for id 1 and 2 are numeric, whereas 3 onwards are strings. Could you update this so that all are of the same type? I guess all id should be sent as string.

Related to that, the documentation says that the IDs should be numeric, but the API sends them as string.

quarian commented 4 years ago

Huh, thanks for noticing! The docs should be fixed in https://github.com/HS-Datadesk/koronavirus-avoindata/pull/32, and the data should be now formatted correctly. If you agree, let's close this issue.

@lovelldies

lovelldies commented 4 years ago

Thanks @quarian!