search

HSAnet / reverse-traceroute

An implementation of reverse traceroute
GNU General Public License v3.0
46 stars 4 forks source link

many warnings when running on interfaces with no broadcast IP set #6

Closed momorientes closed 1 year ago

momorientes commented 1 year ago

For every hop the following messages are repeated when running the client on a host without a configured broadcast address (e.g. when only a /32 is assigned to the interface). This is very noisy and not required.

INFO:src.core.engine:Probing hop with TTL 7
WARNING: more No broadcast address found for iface eth0

WARNING:scapy.runtime:more No broadcast address found for iface eth0

WARNING: No broadcast address found for iface eth0

WARNING:scapy.runtime:No broadcast address found for iface eth0

WARNING: No broadcast address found for iface eth0

WARNING:scapy.runtime:No broadcast address found for iface eth0

WARNING: more No broadcast address found for iface eth0

WARNING:scapy.runtime:more No broadcast address found for iface eth0
vhein99 commented 1 year ago

Your problem should be fixed by commit fec7edf9eccbf2e817c029f374fea0118ecff53a. Warnings should now be displayed only once. Could you update your client and provide feedback whether it works for you?

momorientes commented 1 year ago

The messages are now only displayed on the first hop, however still four times

INFO:src.core.engine:Probing hop with TTL 1
WARNING: No broadcast address found for iface eth0

WARNING:scapy.runtime:No broadcast address found for iface eth0

WARNING: more No broadcast address found for iface eth0

WARNING:scapy.runtime:more No broadcast address found for iface eth0
INFO:src.core.container:Added new Vertex(address=172.31.1.1) to Hop(ttl=1, len=1)
INFO:src.core.engine:Probing hop with TTL 2
INFO:src.core.container:Added new Vertex(address=95.216.131.79) to Hop(ttl=2, len=1)
INFO:src.core.engine:Probing hop with TTL 3
[...]
vhein99 commented 1 year ago

Thanks for your feedback. I once again pushed a commit ba3f80db8971ed17596e2d10227bfed6bba87ce7 to resolve the issue. Now all scapy warnings starting with "more" are filtered and duplicate log entries shouldn't appear anymore. I would appreciate your feedback whether this solves your problem.

momorientes commented 1 year ago

Looks good to me!

~# augsburg-traceroute two-way tcp multipath reversetraceroute.globalways.net
INFO:src.core.engine:Probing hop with TTL 1
WARNING: No broadcast address found for iface eth0

INFO:src.core.container:Added new Vertex(address=172.31.1.1) to Hop(ttl=1, len=1)
INFO:src.core.engine:Probing hop with TTL 2