HSF / documents

Repository for HSF documents (e.g. technical notes)
6 stars 29 forks source link

Addressed most CSBS journal referees feedback on CWP analysis chapter #113

Closed eduardo-rodrigues closed 5 years ago

davidlange6 commented 5 years ago

On Nov 8, 2018, at 12:47 PM, Eduardo Rodrigues notifications@github.com wrote:

@eduardo-rodrigues commented on this pull request.

In CWP/papers/HSF-CWP-2017-01_roadmap/latex/cwp.bib:

@@ -2372,3 +2371,13 @@ @article{1742-6596-664-8-082046 url={http://stacks.iop.org/1742-6596/664/i=8/a=082046}, year={2015}, } + +@online{Spark,

From looking at your PR, yes, your paper is a good citation to have. But why do you say https://www.scala-lang.org/ is wrong?

because spark and scala are two different things. eg, https://spark.apache.org if you want some generic spark website reference.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

eduardo-rodrigues commented 5 years ago

From my side this PR is ready. @davidlange6, do you want to finalise your review, to try and also get this merged asap? Thanks.

jouvin commented 5 years ago

I have the feeling this PR is ready to be merged, except if I missed something. In this case, I suggest to do it asap so that we can solve potential conflicts with the 2 remaining ones with some pending issues.

eduardo-rodrigues commented 5 years ago

OK, 2 happy people (+me ;-)) … I'm merging. Thanks for the ckecks.

graeme-a-stewart commented 5 years ago

Count me as happy too 👍

eduardo-rodrigues commented 5 years ago

Thanks :-).