search

HSF / hsf.github.io

HEP Software Foundation GitHub website
http://hepsoftwarefoundation.org/
56 stars 317 forks source link

Links not updated on training-center website #1588

Closed martamaja10 closed 1 month ago

martamaja10 commented 1 month ago

My PR to update the ROOT links: https://hsf-training.org/training-center/ was merged two days ago, but the website hasn't updated and the old course is still linked. Also, if I try to go into About I get the file not found error: https://hepsoftwarefoundation.org/workinggroups/training.html .

I also slightly modified the ROOT GSOC description and that part worked fine.

graeme-a-stewart commented 1 month ago

Hi @jpivarski @amorenobr - could you take a look? Is this to do with the way the new training centre is coded? Like a different repo?

jpivarski commented 1 month ago

@ariostas, do you see what the issue is? #1584 updated

What is the intended pathway for changes in these source files to update the final HTML?

ariostas commented 1 month ago

@martamaja10, the training center was moved to https://github.com/hsf-training/training-center since now it's not Jekyll based.

I hadn't removed the training center data from this repo in case we had to roll back, but now it's just making things confusing. Sorry about that! I'll open a PR to remove things and point people to the new repo.

jpivarski commented 1 month ago

That's a good idea. There should be one "source of truth." I think we're now well past the phase where we think we might be rolling back.

Can the old URL be an automatic redirect to the new one?

ariostas commented 1 month ago

Can the old URL be an automatic redirect to the new one?

Yeah, the old URL already redirects to the new one, but on GitHub it's not clear that it moved somewhere else

martamaja10 commented 1 month ago

Thanks for the clarification, I now opened a PR on the other github page, would be great if someone could review and merge it, thanks! https://github.com/hsf-training/training-center/pull/94

ariostas commented 1 month ago

Could someone with the right permissions review and merge #1589? I merged https://github.com/hsf-training/training-center/pull/94, so we can close this issue after that.

amorenobr commented 1 month ago

Done!

graeme-a-stewart commented 1 month ago

Thanks for the fix @ariostas and for raising the issue @martamaja10