search

HSF / phoenix

"Phoenix", an experiment independent web-based event display for High Energy Physics.
https://hepsoftwarefoundation.org/phoenix/
Apache License 2.0
54 stars 53 forks source link

Screenshot icon is missing #654

Open EdwardMoyse opened 5 months ago

EdwardMoyse commented 5 months ago

image

Weirdly, I don't think this happens when running Phoenix locally ... it seems to only happened when Phoenix is deployed.

Tentatively assigning to Sebastien, but I will take a look as well tomorrow.

sponce commented 5 months ago

Thing is I do not know how to reproduce. The LHCb deployment on the web (https://lhcb-eventdisplay.web.cern.ch/) does not seem to have the problem. I've also checked the diff with head of master and nothing seems related to this icon.

Can you tell me how to reproduce ? Which browser, which platform, which webpage ?

EdwardMoyse commented 5 months ago

Hi @sponce - sorry, indeed I was not very clear. One way to reproduce is to install PhoenixATLAS i.e.

git clone https://github.com/ATLAS-experiment/PhoenixATLAS.git
cd PhoenixATLAS
yarn install
yarn start

But actually I noticed something which is probably relevant.

In our instructions we say:

And lastly, download these assets (icons and images used by the Phoenix UI components) and put them in the src/assets directory of your app.

If I look in that directory I see e.g. ss-mode (as used in ss-mode.component.html), but no png.svg. I can't actually find it anywhere in the repo, so I'm not quite sure where it comes from?

Edit: ah, I was just looking under phoenix-ui-components whereas it is here: /packages/phoenix-ng/projects/phoenix-app/src/assets/icons/png.svg

I'm not sure why we have both directories:

./packages/phoenix-ng/projects/phoenix-ui-components/lib/assets/icons
./packages/phoenix-ng/projects/phoenix-app/src/assets/icons/

They have almost identical content.... I wonder if @9inpachi knows?

9inpachi commented 5 months ago

The library doesn't use the files and they are served by the app through an endpoint. They exist in the library as well since they need to be copied over to any application that will use the library.

EdwardMoyse commented 5 months ago

Okay, we we should copy png.svg to /packages/phoenix-ng/projects/phoenix-ui-components/lib/assets/icons?

And I need to copy it as well to PhoenixATLAS?

sponce commented 5 months ago

I'm a bit lost in the structure of all the code, but the file is in packages/phoenix-ng/projects/phoenix-app/src/assets/icons/png.svg and it seems to be sufficient for LHCb to find it. Now it is true that if I check other icons (e.g. clipping.svg) it seems to be duplicated into packages/phoenix-ng/projects/phoenix-ui-components/lib/assets/icons. I'm not sure why everything should be duplicated. Does not look super optimized I must say