HSF / phoenix

"Phoenix", an experiment independent web-based event display for High Energy Physics.
https://hepsoftwarefoundation.org/phoenix/
Apache License 2.0
54 stars 53 forks source link

WARNING: Multiple instances of Three.js being imported. #655

Open EdwardMoyse opened 5 months ago

EdwardMoyse commented 5 months ago

when opening e.g. https://hepsoftwarefoundation.org/phoenix/#/lhcb (but any phoenix instance will show it), I see the following in the log:

WARNING: Multiple instances of Three.js being imported.

This message has been there for ages but apparently this can cause issues such as mem leaks, performance issues, and other undefined behaviour ... so I think we should fix it

9inpachi commented 5 months ago

It's because of JSROOT if I recall correctly.

On Mon, 25 Mar 2024, 3:23 pm Edward Moyse, @.***> wrote:

when opening e.g. https://hepsoftwarefoundation.org/phoenix/#/lhcb (but any phoenix instance will show it), I see the following in the log:

WARNING: Multiple instances of Three.js being imported.

This message has been there for ages but apparently this can cause issues such as mem leaks, performance issues, and other undefined behaviour ... so I think we should fix it

— Reply to this email directly, view it on GitHub https://github.com/HSF/phoenix/issues/655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZVY6N3OOSOFV2FQ5JJ4HLY2AXONAVCNFSM6AAAAABFHDNXX2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDKOBYGM3DMNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

EdwardMoyse commented 5 months ago

Ah seems likely: https://github.com/root-project/jsroot/blob/7a64fb096d51bfa7e87bf36789e0206f78b08d4c/libs/three/package.json

So, there's not much we can do about this. :-(

DraTeots commented 5 months ago

Found this on threejs

https://github.com/mrdoob/three.js/issues/25681

But not sure it is used here. Could this help in Phoenix case?

EdwardMoyse commented 4 months ago

Found this on threejs

mrdoob/three.js#25681

But not sure it is used here. Could this help in Phoenix case?

Unfortunately I think in this case it really is from jsroot.