HSF / phoenix

"Phoenix", an experiment independent web-based event display for High Energy Physics.
https://hepsoftwarefoundation.org/phoenix/
Apache License 2.0
54 stars 53 forks source link

Instructions for adding a new experiment are not (no longer?) working #667

Closed tmadlener closed 2 months ago

tmadlener commented 2 months ago

I was trying to follow these instructions to try and setup an event display for a new experiment. Are these still expected to work? I am mainly asking because I ran into a few issues in a few of my attempts. Any inputs / help would be greatly appreciated.

Main reasons for this issue:

Maybe I am just missing the correct combination of node and angular versions? I am trying this on Ubuntu 22.04 using the following as a base

$ node --version
v20.15.1
$ npm --version
10.7.0

I have also tried with node 18, but without success.

If the instructions are still supposed to work, I can also provide more detailed information about the issues I have run into.

DraTeots commented 2 months ago
ng new my-app --no-standalone --routing true --style scss
  1. It should work with angular 17 as Phoenix uses angular 17
  2. With getting started finished on your side, ng serve same as npm run start will work, but ng build will not. It has much more deep issues and I was not able to make ng build work without severe builder reconfiguration. Don't fall into this trap.
DraTeots commented 2 months ago

@EdwardMoyse If you would like, I can rewrite this tutorial to use standalone controls and simplify it for newcomers.

EdwardMoyse commented 2 months ago

That would be fantastic! Please feel free to rewrite it.

tmadlener commented 2 months ago

I would also really appreciate that and volunteer for testing.

Just for completeness: I got the the example app from angular to run, but things started to fail for me once I tried to added a new component for the experiment. However, that could also just be me being stupid and not knowing enough about angular to fix a few potentially smaller issues or misunderstanding the instructions.

DraTeots commented 2 months ago

Here is the PR #668

EdwardMoyse commented 2 months ago

Again, apologies for the long delay, but I think we can close this now (thanks to @DraTeots )