DT-6257: Mobile time picker does not allow user to type . in input field - Githubissues

HSLdevcom / digitransit-ui

Digitransit UI ("Reittiopas.fi")

https://www.reittiopas.fi/

Other

239 stars 132 forks source link

DT-6257: Mobile time picker does not allow user to type . in input field #4965

Closed Antiik91 closed 6 months ago

Antiik91 commented 7 months ago

Proposed Changes

Mobile timepicker improvements:

Instead of alllowing period, change the marking to colon.
Do not accept multiple colons, since we do not accept seconds in our input.
Code cleanup: validateInput now returns true if the input is valid.

Pull Request Check List
A reasonable set of unit tests is included
Console does not show new warnings/errors
Changes are documented or they are self explanatory
This pull request does not have any merge conflicts
All existing tests pass in CI build

Review

Read and verify the code changes
Test the functionality by running the UI locally with all popular browsers available in your platform
Check that the implementation matches the design, when such one is defined in a Jira issue
Merge the pull request