Bump Node from v18 to v20 - Githubissues

HSLdevcom / digitransit-ui

Digitransit UI ("Reittiopas.fi")

https://www.reittiopas.fi/

Other

237 stars 130 forks source link

Bump Node from v18 to v20 #5005

Closed hbruch closed 1 month ago

hbruch commented 1 month ago

This is an alternative PR for #5003 to update node even further to currently active v20, which, as even numbered version will be LTS and maintained until spring 2026.

Proposed Changes

bump node from v16 via v18 to v20 (intermediate commits could be squashed before merge)
bump sharp resolution from 0.31.3 to 0.33 (permits use of docker image node20:alpine which currently is based on alpine 3.19 and otherwise would result into compilation issues, see https://github.com/nodejs/docker-node/issues/2009).

Pull Request Check List

~~A reasonable set of unit tests is included~~
Console does not show new warnings/errors
Changes are documented or they are self explanatory
This pull request does not have any merge conflicts
All existing tests pass in CI build

Review

Read and verify the code changes
Test the functionality by running the UI locally with all popular browsers available in your platform
Check that the implementation matches the design, when such one is defined in a Jira issue
Merge the pull request

vesameskanen commented 1 month ago

Thanks for a valuable contribution! Everything seems to work very well. I believe we will merge this PR right after our next production release 3rd June.