DT-6182 rental scooters - Githubissues

HSLdevcom / digitransit-ui

Digitransit UI ("Reittiopas.fi")

https://www.reittiopas.fi/

Other

237 stars 130 forks source link

DT-6182 rental scooters #5016

Closed sharhio closed 6 days ago

sharhio commented 2 weeks ago

Proposed Changes

Scooters added to routes and map.
Scooters configured for HSL and Matka (Helsinki only)

When testing

Ensure that otp is configured properly (see data-container pr)
UI map layer configuration uses the local otp instead of dev.

Relies on: https://github.com/HSLdevcom/OpenTripPlanner-data-container/pull/403 https://github.com/opentripplanner/OpenTripPlanner/pull/5909

Pull Request Check List

A reasonable set of unit tests is included
Console does not show new warnings/errors
Changes are documented or they are self explanatory
This pull request does not have any merge conflicts
All existing tests pass in CI build

Review

Read and verify the code changes
Test the functionality by running the UI locally with all popular browsers available in your platform
Check that the implementation matches the design, when such one is defined in a Jira issue
Merge the pull request

vesameskanen commented 2 weeks ago

This is a mighty PR! Review will take days.

To get started, fix all new linter warnings. It is not hard - you have already added rentalVehicleShape. Just use the shapes.

vesameskanen commented 6 days ago

I added some minor fixes and refactored the code. There might be still a need for renaming more citybike things to a generic form.