search

HSLdevcom / helmet-model-system

European Union Public License 1.2
10 stars 3 forks source link

Fix headways in extra waiting times #485

Closed johpiip closed 1 year ago

johpiip commented 1 year ago

Fixes a bug where headways in function _calc_extra_wait_time() were read from Emme networks instead of extra attributes. This caused the first model run to have different results than the following model runs, because the first run reads them from transit_lines_xxx.txt and other runs read them from the last congested transit assignment i.e. @hw_iht: https://github.com/HSLdevcom/helmet-model-system/blob/089f9c43113a97aaf5e9e975887eddf07ebe2330/Scripts/assignment/assignment_period.py#L766-L769

Fixes #484

johpiip commented 1 year ago

Thanks and don't worry @zptro! Should I make a similar PR to master for v4.0 or is it considered to be at its end-of-life?

zptro commented 1 year ago

Thanks and don't worry @zptro! Should I make a similar PR to master for v4.0 or is it considered to be at its end-of-life?

Good question. I am probably not the one to decide this, but maybe it can be considered EOL.