HSLdevcom / jore4

Public transport registry
European Union Public License 1.2
4 stars 2 forks source link

Timetable file upload behaves unintuitively #1548

Closed niknii-vincit closed 8 months ago

niknii-vincit commented 11 months ago

After choosing a timetable file to upload, one can not delete the already chosen file, except by browsing for a new file and canceling the process.

The same process also deletes previously chosen files, if one wants to add other files into the same upload, so all files need to be chosen in the same browse session.

Design proposal in Figma for when the import view reflects the status in staging.

https://github.com/HSLdevcom/jore4/assets/135983800/5b281bc2-3a39-4b48-b32e-f46fe7357180

Proposed tasklist:

  1. Add delete chosen file button
  2. Research if the file can be kept when opening a new file browse event
  3. Enable user to add a 2nd file afterwards

See also #1615 and combine if same thing

HenrikHartiala commented 10 months ago

This is not a bug, this is a MVP implementation of the the feature. The whole thing might change in the future, if we want to remove the file loading and combine it with the staging and change the designs of this. But currently for the MVP, this has all the features (you can add / remove one or multiple files). The user can drag and drop multiple files. Also currently if the user wants to choose files in batches, he/she can always upload the files in between:

  1. Choose 3 files from folder X
  2. Upload
  3. Choos next 5 files from folder Y
  4. Upload 5 ...

After the upload, the files go to the staging state anyway. But like said above, this might change in the future iterations.

niknii-vincit commented 8 months ago

What do you think @ellinooraikaheimo, should this be kept in the backlog as a QoL update in the future, or close altogether?

ellinooraikaheimo commented 8 months ago

Closing seems like a valid option. We can discuss this tomorrow at the backlog refinement, @niknii-vincit you could present the case and we'll discuss the actions together

ellinooraikaheimo commented 8 months ago

Closed as not planned, this is not part of MVP, new ticket will be created by @juhakolari about the fix for after MVP development phase.