search

HSLdevcom / jore4

Public transport registry
European Union Public License 1.2
4 stars 2 forks source link

Distance between stops reported inconsistent numbers #1744

Open culka opened 3 months ago

culka commented 3 months ago

Running E2E tests produced

'route;123;line 123;0;0;0
rvariant;2;route 123;1;0;1232;123
rvpoint;1AACKT;0.000;1;0;0;H1234;1232
rvpoint;;;0;0;0;H1235;1232
rvpoint;1AURLA;0.412;1;0;0;H1236;1232
stop;H1234;00;kuvaus;beskrivning;katu;gata;1AACKT;60.164181;24.926700;H1234
stop;H1235;00;kuvaus;beskrivning;katu;gata;1ELIMK;60.164908;24.929042;H1235
stop;H1236;00;kuvaus;beskrivning;katu;gata;1AURLA;60.166003;24.932072;H1236
place;1AACKT;1AACKT\nplace;1ELIMK;1ELIMK
place;1AURLA;1AURLA
stpdist;H1234;H1235;1;118
stpdist;H1235;H1236;1;293'

When the exptected values were

'route;123;line 123;0;0;0
rvariant;2;route 123;1;0;1232;123
rvpoint;1AACKT;0.000;1;0;0;H1234;1232
rvpoint;;;0;0;0;H1235;1232
rvpoint;1AURLA;0.190;1;0;0;H1236;1232
stop;H1234;00;kuvaus;beskrivning;katu;gata;1AACKT;60.164181;24.926700;H1234
stop;H1235;00;kuvaus;beskrivning;katu;gata;1ELIMK;60.164908;24.929042;H1235
stop;H1236;00;kuvaus;beskrivning;katu;gata;1AURLA;60.166003;24.932072;H1236
place;1AACKT;1AACKT
place;1ELIMK;1ELIMK
place;1AURLA;1AURLA
stpdist;H1234;H1235;1;35
stpdist;H1235;H1236;1;155'

Of note here are the last values of stpdist, distances between stops, and the third value of the last rvpoint, which is the distance from the previous stop.

When re-running the tests with no other changes made the test completed successfully.

Something caused the distance calculation in the routes and lines database to produce wrong results, this should not happen for any reason and this behavior should be investigated and fixed if the reason is found.

Might relate to #1720

ellinooraikaheimo commented 3 months ago

Prioritize this once the #1720 is done.