HSLdevcom / mal-effect-calculations

Impact assessment scripts for the Helsinki region MAL planning process
https://www.hsl.fi/hsl/mal
European Union Public License 1.2
1 stars 0 forks source link

Update renv and packages #61

Closed johpiip closed 2 years ago

johpiip commented 2 years ago

Cherry-picked commits from another branch...

Environment was updates, so that we can used a newer version or R and newer versions or packages during analysis. To test any unintended changes in results, I ran the analysis on both old and new environment. Data files were compared and only differences were unimportant data type changes, or floating-point errors (change was so small that it is not relevant). Plots were visually compared, and differences were fixed in this PR. So everything went great!

Unfortunately, upgrading packages introduced a performance issue in accessibility calculations (#62). Maybe a future version of dplyr will fix it. Right now, that part is slow but works, so I see no need downgrading packages because the pros outweigh the cons.

Closes #60