HSLdevcom / mal-effect-calculations

Impact assessment scripts for the Helsinki region MAL planning process
https://www.hsl.fi/hsl/mal
European Union Public License 1.2
1 stars 0 forks source link

Update pkgs with R v4.3.0 #69

Closed johpiip closed 1 year ago

johpiip commented 1 year ago

This PR updates R version to 4.3.0 and updates all packages to their latest versions. This PR also removes dependency to MRAN package repository as it is being deprecated. Updating packages mean several adaptations to dependencies, such as:

Results were compared numerically and plots were compared visually.

Accessibility results were not yet compared as we are missing the "before" data due to performance issue. Working on it though!

johpiip commented 1 year ago

Lifecycle warnings:

In scripts/basemap/centers_uusimaa-2050.R:9:

Warning:
Using one column matrices in `filter()` was deprecated in dplyr 1.1.0.
ℹ Please use one dimensional logical vectors instead.

In scripts/figures/links.R:64:

Warning:
Specifying the `id_cols` argument by position was deprecated in tidyr 1.3.0.
ℹ Please explicitly name `id_cols`, like `id_cols = fid`.
johpiip commented 1 year ago

Also this parsing issue in scripts/figures/zones.R, but this may be old and refer to missing columns in syöttödata. I have not yet identified the data frame.

Warning: One or more parsing issues, call `problems()` on your data frame for details, e.g.:
  dat <- vroom(...)
  problems(dat)
johpiip commented 1 year ago
Running analysis in graph_accessibility.R...
Warning: Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
ℹ Please use `linewidth` instead.
johpiip commented 1 year ago

Warnings on comments before this were fixed.