HSU-ANT / gstpeaq

GstPEAQ - A GStreamer plugin for Perceptual Evaluation of Audio Quality (PEAQ)
http://ant.hsu-hh.de/gstpeaq
Other
63 stars 24 forks source link

autogen.sh hardcodes the prefix #1

Closed MathieuDuponchelle closed 7 years ago

MathieuDuponchelle commented 7 years ago

It's possible with gstreamer libraries and most projects with an autogen.sh script to pass --prefix to the script and have it be forwarded to configure, it would be great to have it be the case for gstpeaq as well :)

martinholters commented 7 years ago

Sounds like a good idea. Want to open a PR?

martinholters commented 7 years ago

I guess not, then.

I've just pushed 13954d1c099325adc9f3c508974f8ec79bf17200 which makes autogen.sh pass any options on to configure. They are appended to the hardcoded ones, so a given --prefix takes precedence over the default.

MathieuDuponchelle commented 7 years ago

Thanks, sorry filed and forgot :)

martinholters commented 7 years ago

No worries. The change was super-simple, it just took me a while to get around doing it. If you feel like something more sophisticated would be useful, you're still invited to open a PR with a proposal :wink: