search

HSZemi / mahlowat

mahlowat ist die Implementierung eines Wahlpositionsvergleichswerkzeugs.
MIT License
59 stars 30 forks source link

IE11 errors #4

Closed hoverlord closed 5 years ago

hoverlord commented 5 years ago

Hi! When I open the demo installation with Internet Explorer 11 it is not working, I only see the variable names like "start-explanatory-text". In console, 2 errors are shown: syntax error in de_de.js and Expected ';' in mahlowat.js, Line 313

HSZemi commented 5 years ago

Unfortunately, I do not have an IE 11 available to reproduce your issue. If you can provide me with a pull request that fixes the issue for IE 11 and does not break functionality for major web browsers, I will gladly integrate it.

Werninator commented 5 years ago

There are two errors that came up and there were probably more.

It comes down to the problem of using modern JavaScript functionalities. One simple solution would be to use the babel compiler to compile these into usable code for older browsers without changing the logic in itself.

I ran babel on mahlowat.js and de_de.js and it works perfectly now. It still works on modern browsers on my Mac (Chrome, Firefox, Safari).

HSZemi commented 5 years ago

I adjusted the for-loop in mahlowat.js and ran babel on the translation files. Thank you for the suggestion, @Werninator ! @hoverlord , can you confirm that it works for you now as well?

hoverlord commented 5 years ago

Its working fine now, thanks a lot @Werninator and @HSZemi !