search

HTBox / allReady

This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.
http://www.htbox.org/projects/allready
MIT License
891 stars 627 forks source link

#2291 added in Publish onto the icon on Admin/Campaign #2292

Closed djhmateer closed 6 years ago

stevejgordon commented 6 years ago

@djhmateer - One thing I didn't press during the codeathon as I didn't want to push too much to people too fast was linking the PR to the issue. If you put something like Fixes #2291 in the PR comment it will link it to the original issue. This is great for reviewers as it automatically adds a hyperlink and also, once the PR is merged, the issue is auto-closed.

stevejgordon commented 6 years ago

@djhmateer Thanks for this PR. A subtle change if you wouldn't mind. Thanks!

MisterJames commented 6 years ago

@djhmateer Just a small issue if you wouldn't mind addressing so we can merge? (See Steve's comment)

MisterJames commented 6 years ago

We'll leave this one as-is and pull out the icon if recommended after the rest of the UX review.