search

HTBox / allReady

This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.
http://www.htbox.org/projects/allready
MIT License
891 stars 627 forks source link

#2300 Update jQuery and jQuery Validation to latest stable versions #2303

Closed miroslavpopovic closed 6 years ago

miroslavpopovic commented 6 years ago

Issue #2300.

This pull request updates jQuery from version 2.1.4 to 3.3.1 and jQuery Validation from version 1.13.1 to 1.17.0. Note that dependencies in package.json file are reordered alphabetically by npm install call. I consider this to be the correct order, so I left it like that.

P.S. While testing the changes I noticed some problems, like Volunteer button on a Task not working (TypeError: ko.mapping is undefined), and AllReady.ScenarioTests breaking on some of the tests. This happens on master branch too and is not affected by changes from this pull request. I'll check to see if there are issues for those and create new ones if not.

Edit: Apparently all AllReady.ScenarioTests are working OK on AppVeyor, so it must be some problem with my machines (run tests on two different machines) and issues with ko.mapping and missing jQuery Validation scripts are fixed.

miroslavpopovic commented 6 years ago

My bad on not following the process of working on an issue. Didn't find any info in Getting Started document and I just found the Git Usage for allReady document.

MisterJames commented 6 years ago

Wonderful, thanks @miroslavpopovic!