Clean Build for 2019 - Githubissues

HTBox / allReady

This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.

http://www.htbox.org/projects/allready

MIT License

891 stars 624 forks source link

Clean Build for 2019 #2347

Closed oneolddev closed 5 years ago

oneolddev commented 5 years ago

I attempted to rebuild the web only portion of the allReady on a fresh development system and encountered multiple build issues. This PR should resolve #2343(#2344, #2345, #2346)

oneolddev commented 5 years ago

Hmmm.... interesting. I'm seeing errors running the AllReady.ScenarioTest locally. I'm going to spend some time investigating.

oneolddev commented 5 years ago

Appveyor appears to have had some sporadic issues restoring npm packages. This caused some non-reproducible failures. They seemed to have been resolved by the end of today.

Examination of the output from Appveyor indicated that is was using Gulp 4.0. So I updated gulpfile.js to be compatible. This worked locally.

As for the integration test, the local chromedriver version was 2.33 while appveyor was using 2.45. So local results didn't match up. I think I have a stable fix for that after a couple of hours of trial and error.

oneolddev commented 5 years ago

I'm closing this PR.

Why?

Node 8.15 is being used on the build server. Degrading from Node 10 resolves the Gulp related issues. See #2351
AllReady.ScenarioTest is so old it's difficult to 'fix'. It was much easier to simply upgrade the whole project to Core 2.1 and Canopy 2. Also suspect that some of the underlying instability and inconsistency could have been due to issues in Canopy and Selenium. And upgrading everything should make it much easier to support.