HTFML / chinese-poker

3 stars 2 forks source link

first style brett #18

Closed bcsaxon closed 4 years ago

bcsaxon commented 4 years ago

-moved styles from "homepage" to styles.js

pavel-ilin commented 4 years ago

LGTM!

bcsaxon commented 4 years ago

@jfeng530 @oneilsw

my pushes are linking straight to this PR(you can see in the 3 commits in the tab above) I would need to re-branch or someone might have to delete this running PR if we want to start fresh. I believe...

or there might be a way to only keep the specific commits from the tab above and close the PR?

anyway...

1st commit is commented above. felt, cleaned up styling, homepage logo. 2nd commit unsure? firebase I believe. 3rd commit resolves #12 -added Big2Logo.png and Big2Splash.gif in assets

feel free to swap out either, and they're currently just in there as a place holder until we find something a bit better design-wise.

oneilsw commented 4 years ago

Yea. You are most likely going to have to rebase your code from the new master code. Then from there, add these new changes to that. Merging this will give us a ton of problems. Especially since the folders have been reorganized.