search

HTFML / chinese-poker

3 stars 2 forks source link

Rulespage #39

Closed speckworks closed 4 years ago

speckworks commented 4 years ago

Was up Peoples! I removed the "return home" button at the bottom of the screen. I'm still not encountering the "invalid props" error on my branch that @oneilsw experienced. I'm guessing its an iOS thing and since I'm not running an ios emulator, that's a hard one for me to debug.

speckworks commented 4 years ago

Ok @oneilsw I imported the component from React Native. This Beautiful Parchment Paper should be ready to roll out (and/or scrap as the theming evolves).

oneilsw commented 4 years ago

LGTM

jfeng530 commented 4 years ago

Screen Shot 2020-05-08 at 5 21 20 PM On the IPhone, especially with certain phone sizes, the words cut off on the edges. Perhaps we could include margins to make sure the rules are being displayed properly.

speckworks commented 4 years ago

Yes, of course! Let's get some theme styles going for the whole app, no? Rules page can be styled from style.js. I'll get on it.

On Fri, May 8, 2020, 5:22 PM Jacky Feng notifications@github.com wrote:

[image: Screen Shot 2020-05-08 at 5 21 20 PM] https://user-images.githubusercontent.com/53232050/81450425-62401700-9150-11ea-8d64-1d10378420d4.png On the IPhone, especially with certain phone sizes, the words cut off on the edges. Perhaps we could include margins to make sure the rules are being displayed properly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HTFML/chinese-poker/pull/39#issuecomment-626026520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALICANJIY5XGHMJTK2WIIRDRQRZ2JANCNFSM4M3SWHRQ .