HTMLGuyLLC / jAlert

jQuery alert/modal/lightbox plugin
https://htmlguyllc.github.io/jAlert/
MIT License
76 stars 35 forks source link

modal not centered #11

Closed mandricmihai closed 9 years ago

mandricmihai commented 9 years ago

ddssd The first line of the source page are those

NULL
<!DOCTYPE html>

<html class="no-js" lang="en-US">
<head>

null is from the php code If I delete that null everything is centered but with that null before the doctype is not centered anymore

HTMLGuyLLC commented 9 years ago

Lol i couldn't tell you why having invalid html ruins the centering, but I can tell you that's invalid html. Lol

HTMLGuyLLC commented 9 years ago

BTW, I don't know if you have any need for it, but jTimeout goes well with jAlert: http://flwebsites.biz/jTimeout/

mandricmihai commented 9 years ago

Not needing but looks great :+1: but who knows when I might need it :smiley:

HTMLGuyLLC commented 9 years ago

Cool, it's there for you when you do.

duduironeagle commented 8 years ago

Hello! I managed to solve this problem . Do the following:

Edit the jAlert-v3.js file on line 262 put like this: var viewportHeight = Math.ceil (screen.height),

this solves the modal centering problem when a lot of information are displayed on the screen!

HTMLGuyLLC commented 8 years ago

@duduironeagle - Can you make this change and do a pull request?

duduironeagle commented 8 years ago

@VersatilityWerks - I did not understand what you mean

HTMLGuyLLC commented 8 years ago

Can you create a branch, make the change, and submit a pull request? That way I can just add your changes and you get credit for contributing to the repo?

duduironeagle commented 8 years ago

@VersatilityWerks - I do not know how to do it. Feel free to do what has to be done . I do not require credit.