HTMLGuyLLC / jAlert

jQuery alert/modal/lightbox plugin
https://htmlguyllc.github.io/jAlert/
MIT License
76 stars 35 forks source link

closeOnClick does not work on Safari / IOS #30

Closed skyprimer closed 8 years ago

skyprimer commented 8 years ago

closeOnClick does not work in IOS. On android and browser no problem...

skyprimer commented 8 years ago

Solved by changing jalert-v4.js file line 646;

from $(document).off('mouseup', $.fn.jAlert.onMouseUp); $(document).on('mouseup', $.fn.jAlert.onMouseUp);

to: $(document).off('touchstart', $.fn.jAlert.onMouseUp); $(document).off('touchstart', $.fn.jAlert.onMouseUp);

HTMLGuyLLC commented 8 years ago

Good catch. The only thing I'd recommend is having both events. I'll get this added to master soon!

HTMLGuyLLC commented 8 years ago

Fixed in latest commit