search

HTMLGuyLLC / jAlert

jQuery alert/modal/lightbox plugin
https://htmlguyllc.github.io/jAlert/
MIT License
76 stars 35 forks source link

closeOnEsc removes all keydown events #9

Closed jaltek closed 9 years ago

jaltek commented 9 years ago

Hi,

by using the closeOnEsc option (which is true by default) previous keydown functions from all keys are removed. I think this is caused by 

$(document).off('keydown');

jAlert-v3.js - Line 533

IMHO only the function itself should be unregistered.

HTMLGuyLLC commented 9 years ago

Good point. If you'd like to fork and fix, I'll happily merge. Otherwise, I'll get to it when I get a chance.

HTMLGuyLLC commented 9 years ago

Fixed https://github.com/VersatilityWerks/jAlert/commit/b4bf16c6807056ee4795cf7fa9c7398b513dff9d

jaltek commented 9 years ago

Works like charm. Thx ;)

HTMLGuyLLC commented 9 years ago

Not a problem! Let me know if you need anything else :+1: