search

HTMLMin / Laravel-HTMLMin

A simple HTML minifier for Laravel 5, 6, 7, 8 & 9.
MIT License
1.02k stars 118 forks source link

The whole file that includes bad html is skipped from compression #62

Closed 4r7if3x closed 7 years ago

4r7if3x commented 7 years ago

You've used containsBadHtml function at BladeMinifier class to detect bad html and used shouldMinify function to decide whether skip the whole file that contains these pieces of codes. It was nicer if you took those segments out, minified them separately in case of need and put them back after compressing other codes.

GrahamCampbell commented 7 years ago

Skipping the whole file is probably fine I think. Fast enough.

4r7if3x commented 7 years ago

Well, that logic doesn't work for me. May I know why you have skipped inline scripts for example? Any specific reason?

emielmolenaar commented 7 years ago

May I know why you have skipped inline scripts for example? Any specific reason?

Wondering about that too.

4r7if3x commented 7 years ago

@emielmolenaar You may use my patch on that: https://github.com/SamAriafar/Laravel-HTMLMin/tree/patch-1