search

HTPCGuides / pia-port-forwarding-scripts

PIA Port forwarding scripts
http://www.htpcguides.com/
9 stars 5 forks source link

Deprecate as insecure, replace with new API version? #3

Open inspector71 opened 5 years ago

inspector71 commented 5 years ago

Looks like PIA now support accessing the port forward information via an API that does not require insecure passing of credential via GET parameters.

Perhaps this script should be deprecated lest someone uses it (like I did) without properly considering the security exposure possibilities?

HTPCGuides commented 5 years ago

Feel free to make a pull request with the updated secure version you have working, it would be great to have this working for others too :)

inspector71 commented 5 years ago

Agreed, as the PIA script to use their new API does not seem to factor in setting the port in Transmission (or any other software).

Alas, shell scripting is not a strength of mine but if I come up with something, I'll share it around.

Thanks for the current version, BTW. Hope my issue lodgement did not come across as overly critical, if at all.

inspector71 commented 5 years ago

Added a pull request to hopefully solve this issue. Did not realise another user had already done so in 2017.