search

HTR-United / schema

Repository for schema related business
Mozilla Public License 2.0
1 stars 1 forks source link

2023 06 26 #18

Closed PonteIneptique closed 1 year ago

PonteIneptique commented 1 year ago

Hey :) This is a fix for two recent issues:

It should fix:

It should help for:

PonteIneptique commented 1 year ago

Once merge, it needs to be added in the form.

alix-tz commented 1 year ago

Hello! It looks good to me!

I'm wondering if there could be another way to implement the "automatically-aligned" component to prepare the way for other flags, such as "silver dataset".

But, since this would require further discussions, I think it's ok to keep it for a future version.

PonteIneptique commented 1 year ago

I thought about a flag dict property, but it feels like it would be a lot of pre-over-engineering right now.

On Sun, 25 Jun 2023, 6:14 pm Alix Chagué, @.***> wrote:

Hello! It looks good to me!

I'm wondering if there could be another way to implement the "automatically-aligned" component to prepare the way for other flags, such as "silver dataset".

But, since this would require further discussions, I think it's ok to keep it for a future version.

— Reply to this email directly, view it on GitHub https://github.com/HTR-United/schema/pull/18#issuecomment-1606146815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOXEZUM6PCF5HR4G5UJ3OLXNBPWDANCNFSM6AAAAAAZS73X4I . You are receiving this because you authored the thread.Message ID: @.***>

alix-tz commented 1 year ago

Ok! I suggest we merge to create this new version, then we can work on the integration on the website!