Ran all python code through black, code formater

HTTP-APIs / hydra-openapi-parser

OpenAPI to Hydra parser

MIT License

9 stars 9 forks source link

Ran all python code through black, code formater #16

Closed de-sh closed 5 years ago

de-sh commented 5 years ago

Fixes un-formatted code with black

Checklist

[x] My branch is up-to-date with upstream/develop branch.
[x] Everything works and tested for Python 3.5.2 and above.

Description

The Black code formatter library is a python standard for maintaining readable code bases, I have run the code of the parser through it to make it more readable and PEP8 compliant.

Change logs

Code formatted with black

Mec-iS commented 5 years ago

See my review. We cannot really change the styling library every time, we have always been using pep8 package as far as I remember

de-sh commented 5 years ago

See my review. We cannot really change the styling library every time, we have always been using pep8 package as far as I remember.

Ok, These were a suggestion based on the output of black, put it up for review, seems like this is not necessary... comments?

The PR can be closed if it seems to be unnecessary :+1:

chrizandr commented 5 years ago

I agree, we already have PEP8 based code formatting in all other repos. It would make more sense to stick to it than to change the format to something new. I don't potentially see any benefit in switching over to black.

EDIT: If you can give some insights as to why you think this is better, we might be open to more discussion about this. Otherwise I will close the PR.

de-sh commented 5 years ago

@chrizandr I thought python/black is provided by the PSF and hence using it would be better. There is no other reasoning and I have since come to think of not using a no compromise code formatter. I believe it's better to close this PR