HTTP-APIs / hydrus

REST server - Flask Hydra-powered for Semantic Web
https://pypi.org/project/hydrus/
MIT License
195 stars 130 forks source link

Host domain is hardcoded to "localhost". Doesn't change after changing hydrus_server_url in deployment #602

Closed farazkhanfk7 closed 3 years ago

farazkhanfk7 commented 3 years ago

I'm submitting a

Current Behaviour:

I was trying to deploy the docker-container after changing the hydrus_server_url and found a possible bug, which wasn't allowing us to change it to something else other than "localhost:{PORT}". In hydrus/conf.py it was hardcoded to "localhost". Didn't caught this issue before because we were always using localhost and didn't deployed the server.

Expected Behaviour:

hydrus should use server_url provided by user in app.py/cli.py and use it throughout hydrus.

Steps to reproduce:

Snapshot:

Environment:

* python version * pip version * OS details ### Do you want to work on this issue?

Yes