search

HTTPArchive / custom-metrics

Custom metrics to use with WebPageTest agents
Apache License 2.0
19 stars 22 forks source link

Added a custom metric to store local and session storage keys and val… #123

Closed shaoormunir closed 1 month ago

shaoormunir commented 3 months ago

This PR adds a new custom metric to capture and return all key-value pairs from localStorage and sessionStorage of the first-party website.

Changes

Testing was done on the webpagetest.org.

Test websites:

tunetheweb commented 3 months ago

This has the potential to be quite large (10MB or more per domain). I think we should limit each value to the first X bytes (for some value of X) and/or exclude large base64 pieces of data (which could be encoded pictures).

WDYT?

shaoormunir commented 3 months ago

@tunetheweb I agree with the size issue, will add a few size and length constraints while storing values.

tunetheweb commented 3 months ago

Any update @shaoormunir as we have one week to get this reviewed and merged and have a growing queue of other metrics too.

shaoormunir commented 3 months ago

@tunetheweb updated to only store the first 256 bytes for each local and session storage item

github-actions[bot] commented 3 months ago
Custom metrics for https://almanac.httparchive.org/en/2022/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=240607_0K_6
Custom metrics for https://tmz.com WPT test run results: http://webpagetest.httparchive.org/results.php?test=240607_MT_7 Changed custom metrics values: ```json { "_local_session_storage_key_values": null, "_local_storage_api_calls": null, "_localstorage_size": null } ```
Custom metrics for https://cnn.com WPT test run results: http://webpagetest.httparchive.org/results.php?test=240607_AT_8 Changed custom metrics values: ```json { "_local_session_storage_key_values": { "allLocalStorage": { "_cb_svref": "external", "bounceClientVisit340v": "N4IgNgDiBcIBYBcEQM4FIDMBBNAmAYnvgO6kB0AxgHZWUD2AtkSADQgBOMIrIApgB4wAjAHZRIgCwBWCSICc03GwCWKAPoBzOmpS8UKZXSowAZgEMwuleo0Qdeg0dMXdAXyA", "wmFeatureFlagConfigEtag-psmFFClient-CNN-cnn.com": "\"7b1bf6bcfcce4beffdc2e1e0f8d73d6f\"", "prismCE.afd1605e-af1a-4a27-aa52-47bdc5cd961e.reclaimStart": "null", "OB-CCPA": "1---", "panoramaId": "c7fcd890b72bb865dd276fdcffe1185ca02ca8d1bf25a0ce0c5f587a2cfe9cd7", "btUserIsFromRestrictedCountry": "false", "_cb": "2nyHsBjpVzMpZMbe", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$session_state": "{\"lastSessionTimestamp\":1717743655207,\"sessionId\":\"433ff075-e35b-4733-869e-2d0fd053b209\"}", "btUserCountryExpiry": "1717743972109", "id5id_429_nb": "0", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$visitor_profile": "{\"profile\":{\"visitorId\":\"oeu1717743655198r0.8544789804275936\",\"customBehavior\":{},\"first_session\":true,\"browserId\":\"gc\",\"browserVersion\":\"125.0.0.0\",\"device\":\"desktop\",\"device_type\":\"desktop_laptop\",\"referrer\":null,\"source_type\":\"direct\",\"cookies\":{},\"curr", "_v__chartbeat3_expires": "1751871674380", "IXWRAPPERMerkleIp": "{\"t\":1717743665178,\"d\":{\"response\":\"pass\",\"version\":\"1.4.2\"},\"e\":1717830065178}", "panoramaId_expiry": "1718348482117", "panoramaId_expiry_exp": "1718348482117", "_lc2_fpi": "d7ea6f2d6e56--01hzrr1038za8pnwaty3eknc1z", "CNNgoFreePreview": "{\"nextSweep\":1717819200,\"dayCount\":1,\"dayAuthenticated\":null}", "id5id_last": "Fri, 07 Jun 2024 07:01:26 GMT", "id5id_429_nb_exp": "Sun, 07 Jul 2024 07:01:26 GMT", "optimizely_data$$pending_events": "{}", "id5id": "%7B%22signature%22%3A%22ID5_AkQ4UImzQvS7EgcYIz9PhS3ejCU9xPSw1jwghUfkikM8e5cQBbfgJJTk1QZRAG5c5tKgjvzDIYn85KQwainE0UAcFdK7qkzqwHdgpb6aoXKpXhYuMT6cRk1CJVp7xHgYIUKcQa809P542Hmp7YI%22%2C%22created_at%22%3A%222024-06-07T07%3A01%3A25.85576381Z%22%2C%22id5_consent", "wmFeatureFlagResults-psmFFClient-CNN-cnn.com": "[{\"flagId\":\"inBrainTemplateBeta\",\"flagName\":\"inBrainTemplateBeta\",\"enabled\":false,\"updatedSinceLastQuery\":true,\"clientId\":\"psmFFClient-CNN-cnn.com\",\"userId\":\"1f0b1763-1634-46d0-ab2d-3d7fc9dbba80\",\"userIdType\":\"ffUserId\",\"warnings\":[]},{\"clientId\":\"psmFFCli", "_GESPSK-id5-sync.com": "[\"id5-sync.com\",null,1717743675544,null,null,null,null,null,0,[106]]", "logger.feafd160-5eaf-4a9a-a7aa-5247bdc5cd96.inProgress": "{}", "BT_AA_DETECTION": "{\"ab\":false,\"acceptable\":true}", "OB-AD-BLOCKER-WL-STAT": "false", "_iiq_ab_map": "{\"95\":\"A\"}", "geoData": "washington|DC|20011|US|NA|-400|broadband|38.950|-77.020|511", "OB-lastPageViewInfo": "{\"url\":\"https%3A%2F%2Fwww.cnn.com\",\"previousRequestTime\":1717743665192}", "_iiq_sync_967415132": "1717743675000", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$tracker_optimizely": "{}", "_ccmaid": "3644703144891383871", "wmConfigCacheStart-psmFFClient-CNN-cnn.com": "1717743670526", "OB-AD-BLOCKER-STAT": "false", "prismCE.afd1605e-af1a-4a27-aa52-47bdc5cd961e.ack": "1717743849193", "btUserCountry": "US", "debug": "undefined", "top-player::Conviva.sdkConfig": "{\"clId\":\"1238909502.1715644789.1676466408.525920495\"}", "fave_closed_captions": "Off", "_iiq_fdata_967415132": "{\"callCount\":0,\"failCount\":0,\"noData\":1,\"cttl\":86400000,\"clientType\":2,\"adserverDeviceType\":1,\"terminationCause\":9,\"profile\":\"\",\"siteId\":-1519530886,\"date\":1717743675555}", "ds_u": "{\"v\":\"19aab4bb-2132-4538-86e9-7d126babdc30\",\"e\":1749279664252}", "prismCE.afd1605e-af1a-4a27-aa52-47bdc5cd961e.inProgress": "{}", "cto_bundle": "ohNz_l9vVHVOVjYxZ0pHRGZXWUpoWGRzSW92Z29XaEUwQXNDU3FySDZWMTdXMTFHbEYlMkYxWmIwY2RPRFExeENhS1J1V3dZOHc1Z3R4b1FGb0hvcjFzd3dKeEpmdmFDUDZDamZkWkdxOEQ1THNjdVNOUkZwSGtHQ0VkUkhMWWRUYTAlMkZISU1oR0piZVV0cUNtN3FWT29BeEhDQlFRJTNEJTNE", "zion.adobe_ecid": "{\"id\":\"31437134331062737601979661777992350101\",\"idtype\":\"adobe_ecid\",\"sent\":true}", "criteo_fast_bid": "// Hash: ioxxdjHDzFBt50jsKHcULoEjfPjn7FupHUObUXTEulH1iImcaT1OYYq4nXedv+v6ystL/mciw43eN2N1sBqukEcB1G3yLaozwAQoZarIvpe+op2I8dDWCrnmQL5aA3TRFA2hIGMEsGDPdljIfZlxPKB5Tt8rZMkwd8T+7UEJODk=\n!function(e){\"use strict\";var n=function(e,t){return(n=Object.setPrototype", "_iiq_fdata": "{\"pcid\":\"b5cf91a8-81a9-4999-9999-999999999999\",\"pcidDate\":1717743674306,\"uspapi_value\":\"1---\",\"dbsaved\":\"false\"}", "zion.zaid": "{\"id\":\"e82190a6-ae2a-4725-9f7c-f70cb524df37\",\"idtype\":\"zaid\",\"sent\":true}", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$event_queue": "[{\"eb\":{\"n\":\"home\",\"y\":\"pageview\",\"c\":\"home\"},\"h\":\"69435bcb\",\"tb\":1717743658085,\"ts\":[{\"d\":0,\"i\":0}]},{\"eb\":{\"n\":\"entire_site__domestic\",\"y\":\"pageview\",\"c\":\"other\"},\"h\":\"2590542c\",\"tb\":1717743658088,\"ts\":[{\"d\":0,\"i\":1}]},{\"eb\":{\"n\":\"domestic_homepage__mobi", "id5id_exp": "Thu, 05 Sep 2024 07:01:26 GMT", "connect-location-data": "{\"value\":{\"country\":\"US\",\"consentRequired\":0},\"expiresAt\":1717830064691}", "top-player::cc-settings": "{}", "logger.feafd160-5eaf-4a9a-a7aa-5247bdc5cd96.ack": "1717743849191", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$variation_map": "{}", "IXWRAPPERLiveRampIp": "{\"t\":1717743665175,\"d\":{\"response\":\"pass\",\"version\":\"1.3.0\"},\"e\":1717830065175}", "perm_cnn_regwall_v1": "{\"consecutiveDays\":1,\"dateLastVisited\":\"2024-06-07T07:00:57.207Z\"}", "_li_duid": "d7ea6f2d6e56--01hzrr1038za8pnwaty3eknc1z", "OB-FDE": "0", "wmFeatureFlagUserId-psmFFClient-CNN-cnn.com": "1f0b1763-1634-46d0-ab2d-3d7fc9dbba80", "IH_LGCL_TS": "Fri, 14 Jun 2024 07:01:21 GMT", "OB-USER-TOKEN": "25401b87-4211-4707-9eaa-17478c9accf0", "_ccmsi": "1717743664407_y6nihb0vd|1717743664408", "startdate": "1717743658446", "panoramaId_exp": "1718348482117", "bitmovinplayer_config": "{\"b\":[421671108.31401944,151247999.99841806,49938947.35854596],\"b_t\":1717743849257}", "snowplowOutQueue_zionSp_post2": "[]", "signal-floors-6c9e7e78-0934-4f09-af7b-a25d72803ed3": "{\"ttl\":1717819200000,\"adUnits\":{\"ad_bnr_atf_01\":{\"adUnit\":\"ad_bnr_atf_01\",\"floors\":[{\"floor\":null,\"weight\":0.7},{\"floor\":null,\"weight\":0.2},{\"floor\":0.9,\"weight\":0.05},{\"floor\":null,\"weight\":0.05}]},\"ad_rect_btf_02\":{\"adUnit\":\"ad_rect_btf_02\",\"floors\":[{\"f", "_iiq_ab_percentage_967415132": "95", "_v__chartbeat3": "PoU8CPelebBxeX8K", "logger.feafd160-5eaf-4a9a-a7aa-5247bdc5cd96.queue": "[]", "id5id_privacy_exp": "Sun, 07 Jul 2024 07:01:26 GMT", "optLast30DaysVisitsObject": "[1717743655974]", "_iiq_ch": "{\"0\":\"\\\" Not A;Brand\\\";v=\\\"99\\\", \\\"Chromium\\\";v=\\\"125\\\", \\\"Google Chrome\\\";v=\\\"125\\\"\",\"1\":\"?0\",\"2\":\"\\\"Unknown\\\"\",\"3\":\"\\\"x86\\\"\",\"4\":\"\\\"64\\\"\",\"5\":\"\\\"Model\\\"\",\"6\":\"\\\"0\\\"\",\"7\":\"?0\",\"8\":\"\\\" Not A;Brand\\\";v=\\\"99\\\", \\\"Chromium\\\";v=\\\"125.0.0.0\\\", \\\"Google Chrome\\\"", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$layer_states": "[{\"layerId\":\"27299490132\",\"revision\":\"8414\",\"decisionTicket\":{\"bucketingId\":\"oeu1717743655198r0.8544789804275936\",\"globalHoldback\":0,\"audienceIds\":[],\"activationId\":\"1717743655193\"},\"decision\":{\"layerId\":\"27299490132\",\"experimentId\":null,\"variationId\":null", "optSessionsCount": "1", "optimizely_data$$oeu1717743655198r0.8544789804275936$$131788053$$layer_map": "{}", "prismCE.afd1605e-af1a-4a27-aa52-47bdc5cd961e.queue": "[]", "goog:cached:topics": "[null,1717743677984,3]", "top-player::cc-lang": "off", "_cc_id": "33039e2c635435bae67c6a2dcd22f04b", "__idcontext_2^HIykD": "eyJtYXN0ZXJJRHMiOnsiY29va2llSUQiOiIyaFhjNUxtRElwbjM4MkVtWVpCbE1ncmxBM0YiLCJkZXZpY2VJRCI6IjJoWGM1R3ZyMjlNdzhLcllWbmhBcGFnVHlHNyIsIml2IjoiIiwidiI6IiJ9LCJJRHMiOnsiZGV2aWNlSUQiOiIyaFhjNUd2cjI5TXc4S3JZVm5oQXBhZ1R5RzciLCJjb29raWVJRCI6IjJoWGM1TG1ESXBuMzgyRW1ZWkJs", "logger.feafd160-5eaf-4a9a-a7aa-5247bdc5cd96.reclaimEnd": "null", "criteo_fast_bid_expires": "1717830072151", "_lc2_fpi_meta": "{\"w\":1717743681641}", "wmFeatureFlagConfig-psmFFClient-CNN-cnn.com": "{\"featureFlagLibraryVersion\":\"0.1\",\"flags\":[{\"defaultValue\":false,\"id\":\"inBrainTemplateBeta\",\"cohorts\":[{\"cohortCriteria\":[{\"cohortCriteriaId\":0,\"requiredFieldValues\":[\"tbs\",\"trutv\"],\"requiredFieldName\":\"brand\"}],\"cohortId\":0,\"cohortPriority\":0,\"stickiness", "_chartbeat2": ".1717743664486.1717743664486.1.DPdXJ5BsRmx6CWj7gWCsGMeKBkobqD.1", "_cb_svref_expires": "1717745474399", "IXWRAPPERAdserverOrgIp": "{\"t\":1717743665174,\"d\":{\"response\":\"match\",\"version\":\"1.3.0\",\"data\":{\"source\":\"adserver.org\",\"uids\":[{\"id\":\"4024c858-fbb2-4f83-b827-0b69fea7d3ce\",\"ext\":{\"rtiPartner\":\"TDID\"}},{\"id\":\"FALSE\",\"ext\":{\"rtiPartner\":\"TDID_LOOKUP\"}},{\"id\":\"2024-06-07T07:01:04\",\"ex", "cto_bidid": "AXyo4l83dnFrRGc1UiUyRkI0TkZ6cWVxaGJkR0hXVUtHNGhGN0JXSGIzNlpXMk94TnVRT21CNTVMbDRzb1JEJTJGc0lpTkZOSlNPb1NXSTAlMkZENGNQdGtMYzNYeUR5dyUzRCUzRA", "_cb_expires": "1751871664496", "OB-TPCS": "{\"value\":4,\"expiry\":1718002873689}", "zion.session_v1": "{\"created\":1717743659129,\"expires\":1717745459129,\"updated\":1717743842060,\"value\":\"c3d22528-1da6-49bf-8daf-3878f1b35856\"}", "_chartbeat2_expires": "1751871664504", "visittype": "new", "visitnum": "1", "zion.sp_zaid": "{\"id\":\"e82190a6-ae2a-4725-9f7c-f70cb524df37\",\"idtype\":\"sp_zaid\",\"sent\":true}", "zion.session_history": "[{\"referrer\":\"\",\"source_id\":\"section_homepage1\",\"timestamp\":1717743665346,\"view_id\":\"9a08edb4-450c-4f24-a762-f9f0384a572e\"}]", "prismCE.afd1605e-af1a-4a27-aa52-47bdc5cd961e.reclaimEnd": "null", "id5id_cst": "VyxHLMwsHQ==", "id5id_privacy": "{\"jurisdiction\":\"other\",\"id5_consent\":true}", "logger.feafd160-5eaf-4a9a-a7aa-5247bdc5cd96.reclaimStart": "null", "top-player::cc-enabled": "false", "snowplowOutQueue_zionSp_post2.expires": "1780815842084", "OB-USER-TOKEN-CREATION": "1717743670616" }, "allSessionStorage": { "_ucWBDCons": "{\"consentState\":{\"required\":true,\"data-store\":true,\"ads-contextual\":true,\"ads-person-prof\":true,\"ads-person\":true,\"content-person-prof\":true,\"content-person\":true,\"measure-ads\":true,\"measure-content\":true,\"measure-market\":true,\"product-develop\":true,\"conte", "optSessionStarted": "true", "bxindexsynced": "1", "__idcontext_2^HIykD": "eyJtYXN0ZXJJRHMiOnsiY29va2llSUQiOiIyaFhjNUxtRElwbjM4MkVtWVpCbE1ncmxBM0YiLCJkZXZpY2VJRCI6IjJoWGM1R3ZyMjlNdzhLcllWbmhBcGFnVHlHNyIsIml2IjoiIiwidiI6IiJ9LCJpbmZvIjp7ImlzU3Bvb2ZlZCI6ZmFsc2UsIlBNIjpmYWxzZSwiRE5UIjpmYWxzZSwiZGV2aWNlVGltZXpvbmUiOjAsImV4dGVuc2lvbklE", "bxpbmsynced": "1", "online": "1717743658446", "_ucWBDConf": "{\"cookieDomain\":\".cnn.com\",\"cookieSameSite\":\"None\",\"cookieSecure\":true,\"countryCode\":\"US\",\"domId\":\"3d9a6f21-8e47-43f8-8d58-d86150f3e92b\",\"enableDebug\":false,\"langFromBrowser\":true,\"parentReload\":true,\"regId\":\"global\",\"src\":\"https://cdn.cookielaw.org/script", "__idcontext_2^HIykD_id": "IjE1MDgzNjMwNzY3Nzc1Njk5MTJoWGM1R3ZyMjlNdzhLcllWbmhBcGFnVHlHNyI%3D", "optSessionStartedTime02": "true", "bxmagnitesynced": "1", "optLast30DaysSessionStarted": "true", "BT_sid": "YhASVQU9", "optSessionStartedTime": "1717743655965" } }, "_local_storage_api_calls": { "https://www.cnn.com/": { "numLocalStorage": 30, "numSessionStorage": 14 }, "https://lightning.cnn.com/launch/7be62238e4c3/97fa00444124/launch-2878c87af5e3.min.js": { "numLocalStorage": 26, "numSessionStorage": 12 }, "https://www.cnn.com/media/sites/js/bundles/cnn-adfuel.min.js": { "numLocalStorage": 31, "numSessionStorage": 7 }, "https://cdn.cookielaw.org/scripttemplates/otSDKStub.js": { "numLocalStorage": 1, "numSessionStorage": 6 }, "https://s.ntv.io/serve/load.js": { "numLocalStorage": 7, "numSessionStorage": 3 }, "https://get.s-onetag.com/c15ddde9-ec7d-4a49-b8ca-7a21bc4b943b/tag.min.js": { "numLocalStorage": 11, "numSessionStorage": 0 }, "https://cdn.optimizely.com/public/125375509/s/landingprod.js": { "numLocalStorage": 19, "numSessionStorage": 31 }, "https://a125375509.cdn.optimizely.com/client_storage/a125375509.html": { "numLocalStorage": 2, "numSessionStorage": 0 }, "https://lightning.cnn.com/launch/7be62238e4c3/97fa00444124/15b14008839e/EXb9b8027db27c4833867b28f4c02dbd16-libraryCode_source.min.js": { "numLocalStorage": 4, "numSessionStorage": 8 }, "https://cdn.ml314.com/taglw.js": { "numLocalStorage": 4, "numSessionStorage": 0 }, "https://tag.wknd.ai/340/i.js": { "numLocalStorage": 0, "numSessionStorage": 7 }, "https://static.chartbeat.com/js/chartbeat_video.js": { "numLocalStorage": 1, "numSessionStorage": 0 }, "https://widgets.outbrain.com/outbrain.js": { "numLocalStorage": 15, "numSessionStorage": 0 }, "https://js-sec.indexww.com/ht/p/186948-78534564703284.js": { "numLocalStorage": 10, "numSessionStorage": 0 }, "https://c.amazon-adsystem.com/aax2/apstag.js": { "numLocalStorage": 24, "numSessionStorage": 7 }, "https://securepubads.g.doubleclick.net/tag/js/gpt.js": { "numLocalStorage": 0, "numSessionStorage": 1 }, "https://btloader.com/tag?h=warnermediagroup-com&upapi=true": { "numLocalStorage": 19, "numSessionStorage": 8 }, "https://cdn.cookielaw.org/scripttemplates/202403.1.0/otBannerSdk.js": { "numLocalStorage": 3, "numSessionStorage": 2 }, "https://signal-beacon.s-onetag.com/beacon.min.js": { "numLocalStorage": 3, "numSessionStorage": 0 }, "https://registry.api.cnn.io/bundles/fave/vendor-fb2fd729/vendor": { "numLocalStorage": 2, "numSessionStorage": 0 }, "https://cdn.boomtrain.com/p13n/cnn/p13n.min.js": { "numLocalStorage": 1, "numSessionStorage": 1 }, "https://securepubads.g.doubleclick.net/pagead/managed/js/gpt/m202406030101/pubads_impl.js": { "numLocalStorage": 1, "numSessionStorage": 0 }, "https://lightning.cnn.com/cdp/psm/i/web/release/4.0.0/psm.legacy.min.umd.js": { "numLocalStorage": 22, "numSessionStorage": 3 }, "https://registry.api.cnn.io/bundles/fave/topplayer-de35be6b/topplayer": { "numLocalStorage": 27, "numSessionStorage": 1 }, "https://assets.bounceexchange.com/assets/smart-tag/versioned/main-v2_ab418a901277e9b2f51bda6e9239b784.br.js": { "numLocalStorage": 17, "numSessionStorage": 5 }, "https://assets.bounceexchange.com/assets/smart-tag/versioned/cjs_min_3a843477d8e318f67237a66d0a58c542.js": { "numLocalStorage": 6, "numSessionStorage": 5 }, "https://fundingchoicesmessages.google.com/i/22876227373?ers=3": { "numLocalStorage": 0, "numSessionStorage": 1 }, "https://static.criteo.net/js/ld/publishertag.prebid.144.js": { "numLocalStorage": 12, "numSessionStorage": 0 }, "https://widgets.outbrain.com/widgetOBUserSync/obUserSync.html": { "numLocalStorage": 4, "numSessionStorage": 0 }, "https://assets.bounceexchange.com/assets/smart-tag/versioned/ads-v2_7520a52945aef5105bec4608bab1718f.br.js": { "numLocalStorage": 0, "numSessionStorage": 7 }, "https://cdn.id5-sync.com/api/1.0/esp.js": { "numLocalStorage": 17, "numSessionStorage": 0 }, "https://ads.pubmatic.com/AdServer/js/user_sync.html?kdntuid=1&p=162932&us_privacy=1---": { "numLocalStorage": 9, "numSessionStorage": 0 }, "https://agent.intentiq.com/Agent/6.0331/UniversalID/IIQAgent.js": { "numLocalStorage": 2, "numSessionStorage": 0 }, "https://eus.rubiconproject.com/usync.js": { "numLocalStorage": 4, "numSessionStorage": 4 }, "https://cache-ssl.celtra.com/api/creatives/e054c6ea/compiled/web.js?v=53-843bdbe3b7-moatvideo&secure=1&cachedVariantChoices=W10-&isPurposePreview=0&eventMetadataExperiment=newMeta&inmobi=0&adx-in-banner-video=1": { "numLocalStorage": 9, "numSessionStorage": 0 }, "https://assets.bounceexchange.com/assets/bounce/local_storage_frame17.min.html": { "numLocalStorage": 6, "numSessionStorage": 0 }, "https://ads.pubmatic.com/AdServer/js/user_sync.html?p=156512": { "numLocalStorage": 9, "numSessionStorage": 0 }, "https://ads.pubmatic.com/AdServer/js/pwt/156512/6397/pwt.js": { "numLocalStorage": 12, "numSessionStorage": 1 }, "https://static.criteo.net/js/ld/publishertag.js": { "numLocalStorage": 12, "numSessionStorage": 0 }, "https://s.cdn.turner.com/analytics/comscore/streamsense.5.2.0.160629.min.js": { "numLocalStorage": 2, "numSessionStorage": 0 }, "https://www.google.com/recaptcha/api2/aframe": { "numLocalStorage": 2, "numSessionStorage": 3 } }, "_localstorage_size": 123290 } ```
tunetheweb commented 3 months ago

As discussed in https://github.com/HTTPArchive/custom-metrics/pull/124#issuecomment-2155352026 we should remove the number of calls.

I'm also questioning the value of the local and session storage data. Even with the 256 cap, it still can be quite big looking at the CNN example for example. That makes every single call for custom metrics, or payloads bigger, slower, and more expensive for every single user of the HTTP Archive. Do we have concrete plans for this data to justify that?

rviscomi commented 1 month ago

Closing due to inactivity but feel free to reopen if you're able to address the feedback