HTTPArchive / custom-metrics

Custom metrics to use with WebPageTest agents
Apache License 2.0
19 stars 22 forks source link

fix imagesrcset bug #133

Closed kara closed 2 months ago

kara commented 2 months ago

28% of Angular 17 apps using the image directive have been missing performance data due to errors. Looking into it, it seems that link.imagesrcset is undefined in some of these cases. Grabbing the attribute instead of the prop with link.getAttribute fixes the issue.

See example failure: https://www.webpagetest.org/result/240618_AiDc8Y_E9D/3/details/ See example fix: https://www.webpagetest.org/result/240618_AiDcZ3_E78/2/details/


Test websites:

github-actions[bot] commented 2 months ago
Custom metrics for https://almanac.httparchive.org/en/2022/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=240618_G6_6 Changed custom metrics values: ```json {} ```
Custom metrics for https://exploreti.com/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=240618_DQ_7 Changed custom metrics values: ```json {} ```