search

HTTPArchive / custom-metrics

Custom metrics to use with WebPageTest agents
Apache License 2.0
19 stars 21 forks source link

Javascript 2022 custom metrics #38

Closed kevinfarrugia closed 2 years ago

kevinfarrugia commented 2 years ago

Required for JavaScript 2022

Added custom metric for queueMicrotask and for requestIdleCallback

Test: https://webpagetest.httparchive.org/result/220528_7D_Y/1/details/#waterfall_view_step

javascript_new { ... "requestIdleCallback":1,"queueMicrotask":1 }

Control test: https://webpagetest.httparchive.org/result/220528_14_X/1/details/#waterfall_view_step1

javascript_new { ... "requestIdleCallback":0,"queueMicrotask":0 }
kevinfarrugia commented 2 years ago

Generally, I'm on the fence about the need for chapter-specific metrics when we can query all values from observers.js. Do you think it's worth maintaining explicit metrics?

I don't think we should maintain chapter-specific observers and I can remove these two custom-metrics. Awaiting your confirmation.

rviscomi commented 2 years ago

SGTM, sorry I know you spent time on this