HTTPArchive / custom-metrics

Custom metrics to use with WebPageTest agents
Apache License 2.0
19 stars 21 forks source link

Add an `iframes` custom metric #93

Closed adamsilverstein closed 4 months ago

adamsilverstein commented 1 year ago

Based on the images metric, this one enumerates iframes present on the page including their:

tunetheweb commented 1 year ago

Most of this already exists in the almanac custom metric: https://github.com/HTTPArchive/custom-metrics/blob/main/metric-summary.md#iframes

We should enhance that. Though maybe there’s a good argument to move it to its own file while doing that. WDYT @rviscomi ?

rviscomi commented 1 year ago

I'd like to move more towards grouping custom metrics by chapter, ie markup.js for things like this.

tunetheweb commented 1 year ago

Reminder @adamsilverstein . Wanna update the almanac one short term? Or take on the moving of this to markup.js at the same time as doing your updates?