HTTPArchive / custom-metrics

Custom metrics to use with WebPageTest agents
Apache License 2.0
19 stars 22 forks source link

PR body parsing improvement for test websites #98

Closed max-ostapenko closed 10 months ago

max-ostapenko commented 10 months ago

Fixed issues with escaping markup code.

Related to workflow run issues in #96.

max-ostapenko commented 10 months ago

@tunetheweb seems like workflows in many cases run from base branch, skipping the changes from the head branch.

Again I expected to test the new parsing right here, but had to use a separate repo. Hope I covered it all and it will succeed after merging.

tunetheweb commented 10 months ago

@tunetheweb seems like workflows in many cases run from base branch, skipping the changes from the head branch.

Don't understand what this means? I thought that's what the checkout of the head branch gets around:

https://github.com/HTTPArchive/custom-metrics/blob/f776b3067504d4b36a177cfec2ff2a3fc2421b33/.github/workflows/wpt-test.yml#L15-L19

max-ostapenko commented 10 months ago

The workflow file is fetched even before we do checkout. So there is no way to modify it when the workflow is already running.

Oh, ok. So we should be able to test it running with pull_request event.

github-actions[bot] commented 10 months ago
Custom metrics for https://almanac.httparchive.org/en/2022/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_DM_9
Custom metrics for https://www.example.com/#dfsdf=sd WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_40_B Changed custom metrics values: ```json {} ```
Custom metrics for https://weston.ruter.net/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_ZW_D Changed custom metrics values: ```json {} ```
Custom metrics for https://weston.ruter.net/about/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_NK_F Changed custom metrics values: ```json {} ```
Custom metrics for https://weston.ruter.net/category/wordpress/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_HH_H Changed custom metrics values: ```json {} ```
Custom metrics for https://weston.ruter.net/2023/07/01/running-the-wordpress-plugin-directory-slurper/ WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_36_J Changed custom metrics values: ```json {} ```
max-ostapenko commented 10 months ago

Test description:

In WordPress specific HTTP Archive research, we've so far typically relied on only home pages of each origin. However, home pages tend to have different layout than many other pages have, and our assumptions on e.g. performance are not segmented in any way regarding content type. It would be helpful to e.g. differentiate between specific performance patterns commonly applied on home pages vs on singular posts.

Therefore this PR introduces a WordPress specific content type detection, based on the body classes that the CMS outputs by default. The PR adds 3 fields with information:

Some WebPageTest tests with this logic (using @westonruter's site as test candidate):

Test websites: