search

HTTPArchive / httparchive.org

The HTTP Archive website hosted on App Engine
https://httparchive.org
Apache License 2.0
334 stars 42 forks source link

Support Publisher Ads Audits for Lighthouse #228

Open rviscomi opened 4 years ago

rviscomi commented 4 years ago

See https://developers.google.com/publisher-ads-audits

Is it possible to enable these audits in the HA tests?

cc @brendankenny @pmeenan

pmeenan commented 4 years ago

Doesn't seem likely. As best as I can tell, that is a web service built on top of lighthouse and their audits are not part of lighthouse itself. If they can publish their audits to lighthouse as optional audits then we could probably do it.

brendankenny commented 4 years ago

Also available as a lighthouse plugin! It should be sufficient to install lighthouse-plugin-publisher-ads and add a --plugins lighthouse-plugin-publisher-ads flag to the lighthouse invocation.

It may be worth doing some spot checks for execution time and report size changes and if it's worth it for the extra audits, but as a plugin it only does analysis on already-collected page artifacts, no additional browser gathering, so the additions should be fairly small.

cc @warrengm

brendankenny commented 4 years ago

It should be sufficient to install lighthouse-plugin-publisher-ads and add a --plugins lighthouse-plugin-publisher-ads flag to the lighthouse invocation.

though from devtools_browser.py#L601 it looks like lighthouse might be globally installed on the test runner? If so, there is (was?) a bug that requires lighthouse-plugin-publisher-ads to be locally installed in that case: https://github.com/googleads/publisher-ads-lighthouse-plugin/issues/159

pmeenan commented 4 years ago

Yep, no particularly good reason for it to have to be installed globally but that's how they're all currently configured. I'm watching the issue and can re-visit once that is fixed (or take a look at installing lighthouse locally instead - but that is a bigger deployment change).

romaincurutchet commented 3 years ago

I would like to see the results from this audit in a table. Working with hundreds of publishers, it is particularly useful for me to see how much of their Cumulative Layout Shift issues is due to ads, which I can't get elsewhere.

max-ostapenko commented 1 month ago

@pmeenan is this something feasible already?

pmeenan commented 1 month ago

Doesn't look like there are any technical restrictions. We'd mostly have to decide if we're opening up the lighthouse tests to run with plugins and how we decide what plugins we choose to include (and our comfort level with ongoing support since the plugin hasn't been touched in a year - maybe it just doesn't need updates).

max-ostapenko commented 1 month ago

Now that I looked into it - there are indeed maintenance issues. It doesn't support lighthouse versions after 10.0.1 (and we obviously want the latest). As for me, it's too much effort to consider updates+support in such case.

Very unfortunate, especially since there are even particular audits checking for ads impact on LCP.

@jburger424 Is there a chance of getting a new release?