search

HTTPArchive / httparchive.org

The HTTP Archive website hosted on App Engine
https://httparchive.org
Apache License 2.0
334 stars 42 forks source link

Preview deployment for a website #943

Open max-ostapenko opened 2 weeks ago

max-ostapenko commented 2 weeks ago

To make the website reviews easier it would be nice to have a preview deployment. After merging we could promote it to live version to automate.

Add PR comment with a preview link.

tunetheweb commented 2 weeks ago

The problem with this is the JSON requests are protected by CORS and that's limited to a number of domains:

image

No particular reason for that as it's public, but perhaps would be nicer to support https://*-dot-httparchive.uk.r.appspot.com used for test deploys, but 1) it's not a subdomain, and 2) even if it was access-allow-origin doesn't support wildcard sub-domains AFAIK.

So we'd need to change this to *. Which is maybe a bit more open that it needs to be. Sent you details on how to change it.

The other option is to proxy the JSON calls via the client, so CORS is not an issue?

Anyway, once you sort that out npm run testdeploy creates a random test deploy (you can do npm run testdeploy -- --version=943 to pass a version name. I'm suggesting using the PR or issue number (943 for this issue), which would allow you to redeploy to same version rather than random one.

And, after all that, we'd need to clear down the old versions (GCP doesn't do that automatically).

So yes, nice to have, but we don't deploy it often enough for any of us to have looked to tackle all those issues.