search

HTTPArchive / legacy.httparchive.org

<<THIS REPOSITORY IS DEPRECATED>> The HTTP Archive provides information about website performance such as # of HTTP requests, use of gzip, and amount of JavaScript. This information is recorded over time revealing trends in how the Internet is performing. Built using Open Source software, the code and data are available to everyone allowing researchers large and small to work from a common base.
https://legacy.httparchive.org
Other
328 stars 84 forks source link

wpt_bodies meta description and robots gathering is invalid as the selector used is case sensitive #188

Closed Tiggerito closed 4 years ago

Tiggerito commented 4 years ago

https://github.com/HTTPArchive/legacy.httparchive.org/blob/master/custom_metrics/wpt_bodies.js

It seems that name attribute values are case sensitive, so this line will only get a subset of meta descriptions.

target.total = [...d.querySelectorAll('head meta[name="description"]')].map(e => {

The line should be:

target.total = [...d.querySelectorAll('head meta[name="description"i]')].map(e => {

Same goes for the selectors in the calculateAllRobots function.

rviscomi commented 4 years ago

Fixed by https://github.com/HTTPArchive/legacy.httparchive.org/pull/189