Closed dougsillars closed 3 years ago
comments added.. and that pesky ds store is gone :)
Thanks. Do you have the WPT test URLs corresponding to those results, or were those manual tests in DevTools? It'd be helpful to see the custom metric in action in WPT as a kind of acceptance test to make sure that it runs in that context. The only change you'd need to make is uncommenting line 1. See https://github.com/HTTPArchive/legacy.httparchive.org/blob/master/custom_metrics/README.md#testing for more info on testing custom metrics.
Progress on https://github.com/HTTPArchive/almanac.httparchive.org/issues/2144
Thank you Rick for helping me figure these out (and really for writing most of these :) )
test run for numer_video_nodes:
"num_video_nodes\":6,
test run for video durations this appears to only calculate for videos with the metadata downloaded):
"video_durations\":[10.08,5],
test run for video_attributes_values_counts:
\"video_attributes_values_counts\":[{\"attribute\":\"preload\",\"value\":\"true\",\"count\":6},{\"attribute\":\"playsinline\",\"value\":\"\",\"count\":6},{\"attribute\":\"loop\",\"value\":\"\",\"count\":1},{\"attribute\":\"muted\",\"value\":\"\",\"count\":6}]
test run for video_display_style:
\"video_display_style\":[\"block\",\"block\",\"block\",\"block\",\"block\",\"block\"] (when video is hidden): \"video_display_style\":[\"none\"]
Video Format count and format types
\"video_source_format_count\":[1,1,1,1,1,1],\ "video_source_format_type\":[[\"video\/mp4\"],[\"video\/mp4\"],[\"video\/mp4\"],[\"video\/mp4\"],[\"video\/mp4\"],[\"video\/mp4\"]]
(the two above with more than one source):
"video_source_format_count\":[3,3,3,3,3,3,3,3,3],\"video_source_format_type\":[[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],[\"video/webm\",\"video/mp4\",\"video/ogg\"],